Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support to dispose the Action #599

Merged
merged 14 commits into from
Jan 11, 2022
Merged

feat: support to dispose the Action #599

merged 14 commits into from
Jan 11, 2022

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Jan 5, 2022 •
edited
Loading

Description

Allow the developer to dispose the registered Action via ExtensionService

Resolved #545

Changes

  • Add disposable return type to registerAction method of ExtensionService
  • Add IDisposable interface
  • Add use case for disposing of action
  • Add unit test for registerAction
  • Extract the Action2, registerAction into action.ts

@wewoor wewoor added the enhancement New feature or request label Jan 5, 2022
@wewoor wewoor added this to the 0.9.0-beta.2 milestone Jan 5, 2022
@wewoor wewoor self-assigned this Jan 5, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022 •
edited
Loading

Codecov Report

Merging #599 (b2684e1) into main (7229fc5) will increase coverage by 1.59%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   87.28%   88.88%   +1.59%     
==========================================
  Files         190      185       -5     
  Lines        5578     5409     -169     
  Branches     1243     1218      -25     
==========================================
- Hits         4869     4808      -61     
+ Misses        699      593     -106     
+ Partials       10        8       -2
Impacted Files Coverage Δ
src/controller/extension.ts 100.00% <ø> (ø)
src/i18n/selectLocaleAction.ts 9.75% <ø> (ø)
src/monaco/common.ts 100.00% <ø> (+39.28%) ⬆️
src/monaco/quickAccessSettingsAction.ts 71.42% <ø> (ø)
src/monaco/quickAccessViewAction.ts 10.41% <ø> (ø)
src/monaco/quickCopyLineUp.ts 75.00% <ø> (ø)
src/monaco/quickCreateFile.ts 75.00% <ø> (ø)
src/monaco/quickRedo.ts 25.00% <ø> (ø)
src/monaco/quickTogglePanelAction.ts 60.00% <ø> (ø)
src/monaco/quickToggleSideBarAction.ts 44.44% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7229fc5...b2684e1. Read the comment docs.

mortalYoung
mortalYoung approved these changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit bfdf0bb into main Jan 11, 2022
@wewoor wewoor deleted the feat/rmAction branch January 11, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortalYoung mortalYoung mortalYoung approved these changes

@kiwiwong kiwiwong Awaiting requested review from kiwiwong

Assignees

@wewoor wewoor

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.0-beta.2
Development

Successfully merging this pull request may close these issues.

Provide the API of removing QuickAccess or Keybinding Action
2 participants
@wewoor @mortalYoung